-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: setuptools is a required runtime dependency #8107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hmm I think easier to simply eliminate the need for pkg_resources - not sure why this is in their in the first place |
cc @jacobschaer can u just do gflags.version (or similar)? |
cc @jacobschaer ? |
@jreback I seem to recall Google was doing something weird with their version strings before. I'd have to look to see if that's still the case. Isn't setuptools a requirement for pandas anyways? @sean-schaefer |
@jacobschaer Any way to eliminate its usage (e.g. using LooseVersion)? |
Was looking into this - I'm having some account issues with GBQ for integration testing, but it looks like using:
works. However, that's only part of the |
I don't mind that setup tools is require for gbq |
@jacobschaer status? |
During testing, I exceed a rate limiter in BQ (my bad - had two tests running at once on accident). I'll re-run the integration test later. I haven't tried removing setuptools from the virtual enviroment, but I can't see why this wouldn't work. #8409 |
Integration test finally passed locally. Still need to validate that it actually solved the problem... anyone want to try it? :D |
closing in favor of #8409 |
Without setuptools pandas fails to import at https://github.com/pydata/pandas/blob/master/pandas/io/gbq.py#L9